OPTI-4285: Handle partial responses on sideloaded subtitle connector - #129
Merged
Conversation
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ceyhun-o
changed the title
Contributor
|
I think it is fine for now, but on a long term the player internal should respect the partial response and manage the request properly. I would still raise an internal follow-up for this for later. |
Danesz
approved these changes
Sep 9, 2026
therama
approved these changes
Sep 9, 2026
Contributor
|
@ceyhun-o Approved, but I would just add to the list of limitations that we ignore range request. |
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the sideloaded-subtitle connector from forwarding ranged HLS playlist requests.
AVPlayer can initially request a master manifest with
Range: bytes=0-1. When the server responds with206 Partial Contentand body#E, the intercepted loading path can treat those bytes as a complete playlist and fail playback.The connector now removes
RangeandIf-Rangefrom all intercepted playlist requests before storing and returning them. This ensures both the SDK fetch and connector-internal manifest reloads receive complete playlists. Media-segment range requests are not affected.